Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Q
qemu-bcm283x-emu
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Thomas Fjellstrom
  • qemu-bcm283x-emu
  • Repository

Switch branch/tag
  • qemu-bcm283x-emu
  • Makefile.target
Find file
BlameHistoryPermalink
  • Michael S. Tsirkin's avatar
    make: switch from -I to -iquote · 9edc19c9
    Michael S. Tsirkin authored Mar 21, 2018
    Our rule right now is to use <> for external headers,
    "" for internal ones. The idea was to avoid conflicts
    between e.g. a system file named <trace.h> and an
    internal one by the same name.
    
    Unfortunately we use -I compiler flag so it does not
    help: a system file doing #include <trace.h> will
    still pick up ours first.
    
    To fix, switch to -iquote which is supported by both
    gcc and clang and only affects #include "" directives.
    
    As a side effect, this catches any future uses of
     #include <> for internal headers.
    Suggested-by: 's avatarStefan Weil <sw@weilnetz.de>
    Signed-off-by: 's avatarMichael S. Tsirkin <mst@redhat.com>
    Reviewed-by: 's avatarDaniel P. Berrangé <berrange@redhat.com>
    Reviewed-by: 's avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: 's avatarMarcel Apfelbaum <marcel@redhat.com>
    Signed-off-by: 's avatarMarcel Apfelbaum <marcel@redhat.com>
    9edc19c9
Makefile.target 6.5 KB
EditWeb IDE

Replace Makefile.target

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.